refactor: Copy all values when sanitizing #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Jul 31, 2020
request.go
Outdated
| @@ -186,8 +186,8 @@ func (a *Request) Sanitize(allowedParameters []string) Requester { | |||
| b.ID = a.GetID() | |||
| b.Form = url.Values{} | |||
| for k := range a.Form { | |||
There was a problem hiding this comment.
Typically only the first value is set in url.Values but this is still a good merge. It would be nice though to have a test case that covers the fixed behavior to prevent regression.
Huh, what? So strange that this matters. In fact it does not. It seems it is about my master branch being out of date in my fork. |
|
Anyway, trying to rebase killed my branch. I will redo this. |
|
Done in #455. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement when looking at the code.
Getreturns just the first value.