feat: Allow extra fields in introspect response #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
force-pushed
the
extra-fields-in-introspect
branch
from
3cefbfb
to
c2c7ba6
Compare
aeneasr
requested changes
Oct 28, 2020
5 tasks
|
@aeneasr I think I addressed all your comments. |
aeneasr
requested changes
Nov 18, 2020
| @@ -55,7 +55,6 @@ var jwtValidCase = func(tokenType fosite.TokenType) *fosite.Request { | |||
| JWTClaims: &jwt.JWTClaims{ | |||
| Issuer: "fosite", | |||
| Subject: "peter", | |||
| Audience: []string{"group0"}, | |||
There was a problem hiding this comment.
Would this still work though? If so can we add a test to cover this case?
There was a problem hiding this comment.
No, it cannot work because we are filtering out aud from GetExtraClaims. Before the test was in fact buggy, I would claim, and didn't really check if audience is set in the generated (and tested) token. So setting this value does nothing.
| for name, value := range extraClaims { | ||
| switch name { | ||
| // We do not allow these to be set through extra claims. | ||
| case "exp", "client_id", "scope", "iat", "sub", "aud", "username": |
There was a problem hiding this comment.
This is not really possible to limit. Because currently regular claims from JWT tokens are passed through to introspection endpoint using GetExtraClaims. I tried to not do it like that, but I get import cycle. See: 04cd625
aeneasr
added
the
stale
5 tasks
|
I made a followup PR: #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #441.
Proposed changes
Sessions can now implement
GetExtraClaimsto control extra claims in token's introspect output.Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
Further comments
I am not completely satisfied with tests here. For example, there is no test which would check which all fields are really output from introspect for regular access token and for JWT access token. Any suggestion where to add it is welcome.