Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json mappings to default session and its contents #688

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

sgal
Copy link
Contributor

@sgal sgal commented Jul 28, 2022

Related Issue or Design Document

This change adds json mappings to DefaultSession type and its contents to use in enriching the refresh webhook in Hydra here ory/hydra#3204

This is the same as #687 but for master to benefit Hydra v2.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

@aeneasr aeneasr merged commit d8ecac4 into ory:master Jul 29, 2022
@sgal sgal deleted the add-json-mappings-to-default-session-v2 branch July 29, 2022 08:13
cfryanr added a commit to vmware-tanzu/pinniped that referenced this pull request Dec 14, 2022
Most of the changes in this commit are because of these fosite PRs
which changed behavior and/or APIs in fosite:
- ory/fosite#667
- ory/fosite#679 (from me!)
- ory/fosite#675
- ory/fosite#688

Due to the changes in fosite PR #688, we need to bump our storage
version for anything which stores the DefaultSession struct as JSON.
cfryanr added a commit to vmware-tanzu/pinniped that referenced this pull request Dec 14, 2022
Most of the changes in this commit are because of these fosite PRs
which changed behavior and/or APIs in fosite:
- ory/fosite#667
- ory/fosite#679 (from me!)
- ory/fosite#675
- ory/fosite#688

Due to the changes in fosite PR #688, we need to bump our storage
version for anything which stores the DefaultSession struct as JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants