Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM build #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ARM build #151

wants to merge 1 commit into from

Conversation

dewijones92
Copy link

This pull request updates the Makefile to use docker buildx for building Docker images. This change allows us to build multi-platform Docker images for both linux/amd64 and linux/arm64 architectures. This enhancement ensures broader compatibility and support for different environments.

Related Issue or Design Document

This change implements a new feature to support multi-platform Docker builds. No specific issue or design document is linked.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This change was made to ensure that our Docker images are compatible with both linux/amd64 and linux/arm64 architectures. The use of docker buildx was chosen because it provides a straightforward way to build multi-platform images. An alternative approach could have been to maintain separate Dockerfiles for each architecture, but this would have increased maintenance complexity.


@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dewijones92 dewijones92 mentioned this pull request Jun 18, 2024
5 tasks
@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2024

Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can merge it right away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants