Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ID_TOKEN_LIFESPAN when doing refresh #985

Closed
androbi-com opened this issue Aug 13, 2018 · 3 comments
Closed

Use ID_TOKEN_LIFESPAN when doing refresh #985

androbi-com opened this issue Aug 13, 2018 · 3 comments
Assignees
@aeneasr
Labels
bug Something is not working. package/oauth2
Milestone
v1.0.0-rc.1

Comments

@androbi-com
Copy link
Contributor

Do you want to request a feature or report a bug?
possibly bug

What is the current behavior?
The IDToken, when first created has the correct lifespan as indicated by ID_TOKEN_LIFESPAN (I use 1m for testing). However, when I do a refresh_token, the new IDToken has a lifespan of 1h.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  1. Run hydra with ID_TOKEN_LIFESPAN=1m (different from default)
  2. Get a Token with auth code flow, scope openid.
  3. Verify IDToken, it has lifespan ID_TOKEN_LIFESPAN (1 minute)
  4. Wait 1m and refresh token
  5. Verify IDToken, it now has lifespan=1h

What is the expected behavior?
The refreshed IDToken should have a lifespan of ID_TOKEN_LIFESPAN

Which version of the software is affected?
oryd/hydra:unstable (v1.0.0-beta.8). As a sidenote, it would be nice if hydra could print the version number to the logs on startup.
@aeneasr
Copy link
Member

aeneasr commented Aug 13, 2018

That looks like a bug, I'll try to confirm once I'm back in office by end of this week.

@aeneasr aeneasr added the bug Something is not working. label Aug 13, 2018
@aeneasr aeneasr self-assigned this Aug 13, 2018
@aeneasr aeneasr added this to the v1.0.0-rc.1 milestone Aug 13, 2018
@aeneasr aeneasr mentioned this issue Aug 13, 2018
Closed
@aeneasr
Copy link
Member

aeneasr commented Aug 13, 2018 •
edited
Loading

oryd/hydra:unstable (v1.0.0-beta.8). As a sidenote, it would be nice if hydra could print the version number to the logs on startup.

Tracked #987

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2018

Confirmed bug

aeneasr pushed a commit to ory/fosite that referenced this issue Aug 22, 2018
compose: Pass ID Token configuration to strategy
28e6572 
Resolves an issue where expiry and issuer where not properly configurable in the strategy.

See ory/hydra#985

Signed-off-by: arekkas <[email protected]>
@aeneasr aeneasr mentioned this issue Aug 22, 2018
Merged
aeneasr pushed a commit to ory/fosite that referenced this issue Aug 22, 2018
@arekkas
compose: Pass ID Token configuration to strategy (#297)
a07ce27 
Resolves an issue where expiry and issuer where not properly configurable in the strategy.

See ory/hydra#985

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Aug 22, 2018
oauth2: Resolve broken expiry when refreshing id token
3a5bb94 
Closes #985

Signed-off-by: arekkas <[email protected]>
@aeneasr aeneasr mentioned this issue Aug 22, 2018
Merged
aeneasr added a commit that referenced this issue Aug 22, 2018
@aeneasr
oauth2: Resolve broken expiry when refreshing id token (#1002)
c72e64c 
Closes #985

Signed-off-by: arekkas <[email protected]>
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
compose: Pass ID Token configuration to strategy (ory#297)
0950ce7 
Resolves an issue where expiry and issuer where not properly configurable in the strategy.

See ory/hydra#985

Signed-off-by: arekkas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working. package/oauth2
Projects
None yet
Milestone
v1.0.0-rc.1
Development

No branches or pull requests
2 participants
@androbi-com @aeneasr