Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors when calling HandleConsentRequest a second time #1318

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Prevent errors when calling HandleConsentRequest a second time #1318

merged 1 commit into from
Mar 19, 2019

Conversation

kminehart
Copy link
Contributor

@kminehart kminehart commented Mar 18, 2019

Signed-off-by: Kevin Minehart [email protected]

Related issue

#1256

Previous PR: #1301

Proposed changes

If HandleConsentRequest is called a second time, then:

  • If the request was not used (was_used = false), then the old ConsentRequest is replaced with the newly provided data.
  • If the request was used (was_used = true), then the old ConsentRequest is returned, whereas previously a SQL error would be returned.

Checklist

  • I have read the contributing guidelines
  • [ x I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Sorry about messing up the old PR! I tried something new with squashing commits but that backfired when I forgot to sign an older commit. 🤷‍♂️

@aeneasr
Copy link
Member

aeneasr commented Mar 19, 2019

Nice, thank you :)

@aeneasr aeneasr merged commit ac2f23e into ory:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants