Prevent errors when calling HandleConsentRequest a second time #1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Minehart [email protected]
Related issue
#1256
Previous PR: #1301
Proposed changes
If HandleConsentRequest is called a second time, then:
was_used = false
), then the old ConsentRequest is replaced with the newly provided data.was_used = true
), then the old ConsentRequest is returned, whereas previously a SQL error would be returned.Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s
. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>
. Please be very careful when usingforce push.
Further comments
Sorry about messing up the old PR! I tried something new with squashing commits but that backfired when I forgot to sign an older commit. 🤷♂️