Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing to sidebar #2209

Merged
merged 1 commit into from
Dec 1, 2020
Merged

docs: add contributing to sidebar #2209

merged 1 commit into from
Dec 1, 2020

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Nov 30, 2020

Added Contributing Guidelines to the introduction menu point on the sidebar.
I think it should be as obvious as possible.
Another good solution would be to add them to the top bar?

If this is merged, I will do the same changes for Kratos/Oathkeeper/Keto.

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

Added Contributing Guidelines to the introduction menu point on the sidebar. 
I think it should be as obvious as possible. 
Another good solution would be to add them to the top bar?

If this is merged, I will do the same changes for Kratos/Oathkeeper/Keto.
@aeneasr aeneasr merged commit 21f3b1f into ory:master Dec 1, 2020
aeneasr pushed a commit to ory/kratos that referenced this pull request Dec 1, 2020
@vinckr vinckr deleted the patch-14 branch December 1, 2020 14:48
@vinckr vinckr restored the patch-14 branch December 1, 2020 14:48
@vinckr vinckr deleted the patch-14 branch December 1, 2020 14:48
@vinckr vinckr restored the patch-14 branch December 1, 2020 14:48
aeneasr pushed a commit to ory/keto that referenced this pull request Dec 2, 2020
aeneasr pushed a commit to ory/oathkeeper that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants