-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop methods for finding keys by public/private prefix #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
- Coverage 49.87% 49.74% -0.14%
==========================================
Files 236 236
Lines 14974 15032 +58
==========================================
+ Hits 7469 7477 +8
- Misses 6843 6890 +47
- Partials 662 665 +3
Continue to review full report at Codecov.
|
aarmam
force-pushed
the
feature/kid-prefix
branch
from
October 20, 2021 10:36
6b1b73e
to
2a5e55a
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 25, 2021
aarmam
force-pushed
the
feature/kid-prefix
branch
from
October 26, 2021 09:40
4b2cdfd
to
0e21229
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 26, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 26, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 27, 2021
aarmam
force-pushed
the
feature/kid-prefix
branch
from
October 27, 2021 16:27
0e21229
to
929ee21
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 27, 2021
aarmam
force-pushed
the
feature/kid-prefix
branch
from
November 2, 2021 09:24
929ee21
to
060a51b
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 2, 2021
aarmam
force-pushed
the
feature/kid-prefix
branch
2 times, most recently
from
November 8, 2021 08:16
4cad943
to
c9b9bcd
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 8, 2021
aarmam
force-pushed
the
feature/kid-prefix
branch
3 times, most recently
from
November 8, 2021 18:03
d7a67ca
to
c1fb80d
Compare
aarmam
force-pushed
the
feature/kid-prefix
branch
from
November 8, 2021 21:15
c1fb80d
to
5a8e096
Compare
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 9, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 24, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Dec 1, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop FindKeyByPrefix/FindKeysByPrefix methods for finding keys by public/private prefix and use FindPublicKey/FindPrivateKey helper methods instead.
Related issue(s)
This feature is continuation of #2758
It is also related to #2625 where it would be easer to review it, if suggest this change separately.
In short to find keypairs from HSM I use attribute CKA_LABEL as key set id and CKA_ID as key id and they have to be 1:1 for pub/priv keys:
https://github.com/ThalesIgnite/crypto11/blob/master/keys.go#L247-L278
This helps me to get rid of https://github.com/aarmam/hydra/blob/feature/hsm/hsm/manager_hsm.go#L243-L261 where I prefix keys manually altough key id's on HSM are without prefixes.
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.