config: disable plugin backend through 'noplugin' tag #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glerchundi
force-pushed
the
feature/allow-debugging
branch
from
0d8d774
to
8768d32
Compare
|
Are those tests related to my change? |
Debugging Hydra in Go 1.10 and 1.11 (confirmed by one of its members), is not possible due to [this unresolved bug](golang/go#23733) which is related to the use of the plugin functionality. This change allows passing a build tag which will disable plugin implementation and therefore allow to debug in all the use-cases where plugin backend is not needed. Signed-off-by: Gorka Lerchundi Osa <[email protected]>
glerchundi
force-pushed
the
feature/allow-debugging
branch
from
8768d32
to
49ad14b
Compare
glerchundi
changed the title
|
Thanks! |
|
Fantastic, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging Hydra in Go 1.10 and 1.11 (confirmed by one of its members),
is not possible due to this unresolved
bug which is related to the
use of the plugin functionality.
This change allows passing a build tag which will disable plugin
implementation and therefore allow to debug in all the use-cases where
plugin backend is not needed.
Signed-off-by: Gorka Lerchundi Osa [email protected]