feat: include BASE_PATH when redirecting to welcome

[pucke-dev]

Related Issue or Design Document

#259

Checklist

• I have read the contributing guidelines and signed the CLA.
• I have referenced an issue containing the design document if my change introduces a new feature.
• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
  If this pull request addresses a security vulnerability,
  I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added the necessary documentation within the code base (if appropriate).

Further comments

[aeneasr]

I think this is on purpose so that the redirect to welcome is relative and not absolute

[pucke-dev]

I think its still relative, but prefixed with a base path. When using BASE_PATH env the /welcome route also moves to BASE_PATH/welcome, so this redirect shoots into nowhere, and I would ague, this is a inconsistent behavior compared to the other routes. Pls correct me if im wrong @aeneasr

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

pucke-uninow seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}