fix(courier): improve composability

ory · Mar 7, 2022 · d47150e · d47150e
1 parent 598dc3a
commit d47150e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/courier/courier.go b/courier/courier.go
@@ -4,23 +4,23 @@ import (
 	"context"
 	"time"
 
+	"github.com/ory/kratos/courier/template"
+
 	"github.com/cenkalti/backoff"
 	"github.com/gofrs/uuid"
-	"github.com/hashicorp/go-retryablehttp"
 	"github.com/pkg/errors"
 
 	"github.com/ory/kratos/driver/config"
 	"github.com/ory/kratos/x"
 	gomail "github.com/ory/mail/v3"
-	"github.com/ory/x/httpx"
 )
 
 type (
 	Dependencies interface {
 		PersistenceProvider
 		x.LoggingProvider
 		ConfigProvider
-		HTTPClient(ctx context.Context, opts ...httpx.ResilientOptions) *retryablehttp.Client
+		x.HTTPClientProvider
 	}
 
 	Courier interface {
@@ -31,7 +31,7 @@ type (
 		DispatchQueue(ctx context.Context) error
 		DispatchMessage(ctx context.Context, msg Message) error
 		SetGetEmailTemplateType(f func(t EmailTemplate) (TemplateType, error))
-		SetNewEmailTemplateFromMessage(f func(d Dependencies, msg Message) (EmailTemplate, error))
+		SetNewEmailTemplateFromMessage(f func(d template.Dependencies, msg Message) (EmailTemplate, error))
 	}
 
 	Provider interface {

diff --git a/courier/email_templates.go b/courier/email_templates.go
@@ -4,6 +4,8 @@ import (
 	"context"
 	"encoding/json"
 
+	"github.com/ory/kratos/courier/template"
+
 	"github.com/pkg/errors"
 
 	"github.com/ory/kratos/courier/template/email"
@@ -47,7 +49,7 @@ func GetEmailTemplateType(t EmailTemplate) (TemplateType, error) {
 	}
 }
 
-func NewEmailTemplateFromMessage(d Dependencies, msg Message) (EmailTemplate, error) {
+func NewEmailTemplateFromMessage(d template.Dependencies, msg Message) (EmailTemplate, error) {
 	switch msg.TemplateType {
 	case TypeRecoveryInvalid:
 		var t email.RecoveryInvalidModel

diff --git a/courier/smtp.go b/courier/smtp.go
@@ -8,6 +8,8 @@ import (
 	"strconv"
 	"time"
 
+	"github.com/ory/kratos/courier/template"
+
 	"github.com/ory/kratos/driver/config"
 
 	"github.com/gofrs/uuid"
@@ -21,7 +23,7 @@ type smtpClient struct {
 	*gomail.Dialer
 
 	GetTemplateType        func(t EmailTemplate) (TemplateType, error)
-	NewTemplateFromMessage func(d Dependencies, msg Message) (EmailTemplate, error)
+	NewTemplateFromMessage func(d template.Dependencies, msg Message) (EmailTemplate, error)
 }
 
 func newSMTP(ctx context.Context, deps Dependencies) *smtpClient {
@@ -74,7 +76,7 @@ func (c *courier) SetGetEmailTemplateType(f func(t EmailTemplate) (TemplateType,
 	c.smtpClient.GetTemplateType = f
 }
 
-func (c *courier) SetNewEmailTemplateFromMessage(f func(d Dependencies, msg Message) (EmailTemplate, error)) {
+func (c *courier) SetNewEmailTemplateFromMessage(f func(d template.Dependencies, msg Message) (EmailTemplate, error)) {
 	c.smtpClient.NewTemplateFromMessage = f
 }