fix: add continue with only for json browser requests (#4002)

ory · Jul 16, 2024 · e0a4010 · e0a4010
1 parent def6225
commit e0a4010
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/selfservice/flow/login/hook.go b/selfservice/flow/login/hook.go
@@ -159,7 +159,7 @@ func (e *HookExecutor) PostLoginHook(
 		"redirect_reason": "login successful",
 	})...)
 
-	if f.Type == flow.TypeBrowser {
+	if f.Type == flow.TypeBrowser && x.IsJSONRequest(r) {
 		f.AddContinueWith(flow.NewContinueWithRedirectBrowserTo(returnTo.String()))
 	}
 

diff --git a/...gy/totp/.snapshots/TestCompleteLogin-case=totp_payload_is_set_when_identity_has_totp.json b/...gy/totp/.snapshots/TestCompleteLogin-case=totp_payload_is_set_when_identity_has_totp.json
@@ -15,7 +15,6 @@
   {
     "attributes": {
       "disabled": false,
-      "maxlength": 6,
       "name": "totp_code",
       "node_type": "input",
       "required": true,

diff --git a/selfservice/strategy/totp/login.go b/selfservice/strategy/totp/login.go
@@ -50,7 +50,7 @@ func (s *Strategy) PopulateLoginMethod(r *http.Request, requestedAAL identity.Au
 	}
 
 	sr.UI.SetCSRF(s.d.GenerateCSRFToken(r))
-	sr.UI.SetNode(node.NewInputField("totp_code", "", node.TOTPGroup, node.InputAttributeTypeText, node.WithRequiredInputAttribute, node.WithMaxLengthInputAttribute(int(digits))).WithMetaLabel(text.NewInfoLoginTOTPLabel()))
+	sr.UI.SetNode(node.NewInputField("totp_code", "", node.TOTPGroup, node.InputAttributeTypeText, node.WithRequiredInputAttribute).WithMetaLabel(text.NewInfoLoginTOTPLabel()))
 	sr.UI.GetNodes().Append(node.NewInputField("method", s.ID(), node.TOTPGroup, node.InputAttributeTypeSubmit).WithMetaLabel(text.NewInfoLoginTOTP()))
 
 	return nil