Skip to content

Commit

Permalink
test(e2e): resolve privileged regression
Browse files Browse the repository at this point in the history
  • Loading branch information
@aeneasr
aeneasr committed Mar 7, 2022
1 parent da154c5 commit f7dd5ab
Show file tree
Hide file tree
Showing 3 changed files with 202 additions and 127 deletions.
66 changes: 39 additions & 27 deletions test/e2e/cypress/integration/profiles/email/settings/errors.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { appPrefix, gen, website } from '../../../../helpers'
import { routes as react } from '../../../../helpers/react'
import { routes as express } from '../../../../helpers/express'
import {appPrefix, gen, website} from '../../../../helpers'
import {routes as react} from '../../../../helpers/react'
import {routes as express} from '../../../../helpers/express'

context('Settings failures with email profile', () => {
;[
Expand All @@ -16,8 +16,8 @@ context('Settings failures with email profile', () => {
app: 'react' as 'react',
profile: 'spa'
}
].forEach(({ route, profile, app, base }) => {
describe(`for app ${app}`, () => {
].forEach(({route, profile, app, base}) => {
describe.only(`for app ${app}`, () => {
let email = gen.email()
let password = gen.password()

Expand All @@ -32,12 +32,12 @@ context('Settings failures with email profile', () => {
cy.registerApi({
email: emailSecond,
password: passwordSecond,
fields: { 'traits.website': 'https://github.com/ory/kratos' }
fields: {'traits.website': 'https://github.com/ory/kratos'}
})
cy.registerApi({
email,
password,
fields: { 'traits.website': website }
fields: {'traits.website': website}
})
})

Expand All @@ -47,7 +47,7 @@ context('Settings failures with email profile', () => {
cy.visit(base)
cy.clearAllCookies()

cy.login({ email, password, cookieUrl: base })
cy.login({email, password, cookieUrl: base})
cy.visit(route)
})

Expand All @@ -66,13 +66,20 @@ context('Settings failures with email profile', () => {
})

it('fails because reauth is another person', () => {
// Force this because it is hidden
cy.get('input[name="traits.email"]').clear().type(up(email))
cy.shortPrivilegedSessionTime()
cy.get('button[value="profile"]').click()

cy.reauth({
expect: { email },
type: { email: emailSecond, password: passwordSecond }
cy.location().then((loc) => {
cy.get('button[value="profile"]').click()

cy.reauthWithOtherAccount({
previousUrl: loc.toString(),
expect: {email},
type: {email: emailSecond, password: passwordSecond}
})

cy.location('pathname').should('contain', '/settings')
})

// We end up in a new settings flow for the second user
Expand All @@ -94,10 +101,10 @@ context('Settings failures with email profile', () => {
cy.get('button[value="profile"]').click()

cy.clearAllCookies()
cy.login({ email, password, cookieUrl: base })
cy.login({email, password, cookieUrl: base})

cy.getSession().should((session) => {
const { identity } = session
const {identity} = session
expect(identity.traits.email).to.equal(email)
})
})
Expand All @@ -110,7 +117,7 @@ context('Settings failures with email profile', () => {
cy.visit(base)

cy.getSession().should((session) => {
const { identity } = session
const {identity} = session
expect(identity.traits.email).to.equal(email)
})
})
Expand All @@ -130,7 +137,7 @@ context('Settings failures with email profile', () => {
cy.expectSettingsSaved()

cy.getSession().should((session) => {
const { identity } = session
const {identity} = session
expect(identity.traits.email).to.equal(email) // this is NOT up(email)
expect(identity.traits.website).to.equal(
'http://github.com/aeneasr'
Expand Down Expand Up @@ -158,19 +165,24 @@ context('Settings failures with email profile', () => {
})

it('fails because reauth is another person', () => {
cy.shortPrivilegedSessionTime() // wait for the privileged session to time out
cy.get('input[name="password"]').clear().type(up(password))

let firstSession
cy.getSession().then((session) => {
firstSession = session
})

cy.shortPrivilegedSessionTime() // wait for the privileged session to time out
cy.get('button[value="password"]').click()
cy.location().then((loc) => {
cy.get('button[value="password"]').click()

cy.reauthWithOtherAccount({
previousUrl: loc.toString(),
expect: {email},
type: {email: emailSecond, password: passwordSecond}
})

cy.reauth({
expect: { email },
type: { email: emailSecond, password: passwordSecond }
cy.location('pathname').should('contain', '/settings')
})

// We want to ensure that the reauth session is completely different from the one we had in the first place.
Expand Down Expand Up @@ -218,7 +230,7 @@ context('Settings failures with email profile', () => {
cy.get('button[value="password"]').click()

cy.clearAllCookies()
cy.login({ email, password, cookieUrl: base })
cy.login({email, password, cookieUrl: base})
cy.clearAllCookies()
cy.login({
email,
Expand All @@ -235,7 +247,7 @@ context('Settings failures with email profile', () => {
cy.register({
email,
password,
fields: { 'traits.website': website }
fields: {'traits.website': website}
})
cy.visit(route)

Expand All @@ -252,14 +264,14 @@ context('Settings failures with email profile', () => {
cy.get('button[value="password"]').click()

cy.location('pathname').should('include', '/login')
cy.reauth({ expect: { email }, type: { password: password } })
cy.reauth({expect: {email}, type: {password: password}})

cy.location('pathname').should('include', '/settings')
cy.get('input[name="password"]').should('exist')

// This should pass because it is the correct password
cy.clearAllCookies()
cy.login({ email, password: validPassword, cookieUrl: base })
cy.login({email, password: validPassword, cookieUrl: base})

// This should fail because it is the wrong password
cy.clearAllCookies()
Expand All @@ -283,13 +295,13 @@ context('Settings failures with email profile', () => {
describe('global errors', () => {
it('fails when CSRF is incorrect', () => {
cy.get(appPrefix(app) + 'input[name="password"]').type('12345678')
cy.shouldHaveCsrfError({ app })
cy.shouldHaveCsrfError({app})
})

it('fails when a disallowed return_to url is requested', () => {
cy.shouldErrorOnDisallowedReturnTo(
route + '?return_to=https://not-allowed',
{ app }
{app}
)
})
})
Expand Down
Loading

0 comments on commit f7dd5ab

Please sign in to comment.