fix: properly pass context (#2300)

ory · Mar 11, 2022 · fab8a93 · fab8a93
1 parent 47eaae5
commit fab8a93
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/selfservice/flow/login/error.go b/selfservice/flow/login/error.go
@@ -100,7 +100,7 @@ func (s *ErrorHandler) WriteFlowError(w http.ResponseWriter, r *http.Request, f
 		return
 	}
 
-	if err := sortNodes(f.UI.Nodes); err != nil {
+	if err := sortNodes(r.Context(), f.UI.Nodes); err != nil {
 		s.forward(w, r, f, err)
 		return
 	}

diff --git a/selfservice/flow/login/handler.go b/selfservice/flow/login/handler.go
@@ -159,7 +159,7 @@ preLoginHook:
 		}
 	}
 
-	if err := sortNodes(f.UI.Nodes); err != nil {
+	if err := sortNodes(r.Context(), f.UI.Nodes); err != nil {
 		return nil, err
 	}
 
@@ -588,7 +588,7 @@ continueLogin:
 			sess = session.NewInactiveSession()
 		}
 
-		method := ss.CompletedAuthenticationMethod(ctx)
+		method := ss.CompletedAuthenticationMethod(r.Context())
 		sess.CompletedLoginFor(method.Method, method.AAL)
 		i = interim
 		break

diff --git a/selfservice/flow/login/sort.go b/selfservice/flow/login/sort.go
@@ -6,9 +6,7 @@ import (
 	"github.com/ory/kratos/ui/node"
 )
 
-var ctx = context.Background()
-
-func sortNodes(n node.Nodes) error {
+func sortNodes(ctx context.Context, n node.Nodes) error {
 	return n.SortBySchema(ctx,
 		node.SortByGroups([]node.Group{
 			node.OpenIDConnectGroup,

diff --git a/ui/container/container_test.go b/ui/container/container_test.go
@@ -40,9 +40,8 @@ func newFormRequest(t *testing.T, values url.Values) *http.Request {
 	return req
 }
 
-var ctx = context.Background()
-
 func TestContainer(t *testing.T) {
+	var ctx = context.Background()
 	t.Run("method=NewFromJSON", func(t *testing.T) {
 		for k, tc := range []struct {
 			r      string

diff --git a/ui/node/attributes_input_test.go b/ui/node/attributes_input_test.go
@@ -15,9 +15,9 @@ import (
 	"github.com/ory/x/jsonschemax"
 )
 
-var ctx = context.Background()
-
 func TestFieldFromPath(t *testing.T) {
+
+	var ctx = context.Background()
 	t.Run("all properties are properly transferred", func(t *testing.T) {
 		schema, err := ioutil.ReadFile("./fixtures/all_formats.schema.json")
 		require.NoError(t, err)