Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config key neames #1979

Closed
3 of 8 tasks
aeneasr opened this issue Nov 23, 2021 · 0 comments · Fixed by #2261
Closed
3 of 8 tasks

Update config key neames #1979

aeneasr opened this issue Nov 23, 2021 · 0 comments · Fixed by #2261
Assignees
@aeneasr
Labels
feat New feature or request.
Milestone
v0.9.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Nov 23, 2021

Preflight checklist

Describe your problem

  • oidc providers team_* / private_key_* -> apple_*
  • whitelisted_return_urls -> allowed_return_urls

Describe your ideal solution

Workarounds or alternatives

Version

master

Additional Context

No response
@aeneasr aeneasr added the feat New feature or request. label Nov 23, 2021
@aeneasr aeneasr self-assigned this Nov 23, 2021
@aeneasr aeneasr added this to the v0.9.0-alpha.1 milestone Nov 23, 2021
aeneasr added a commit that referenced this issue Feb 25, 2022
@aeneasr
refactor: update apple and microsoft config key names
bb83d91 
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose:

```patch
- private_key_id
+ apple_private_key_id

- private_key
+ apple_private_key

- team_id
+ apple_team_id

- tenant
+ microsoft_tenant
```

Closes #1979
@aeneasr aeneasr mentioned this issue Feb 25, 2022
Merged
7 tasks
aeneasr added a commit that referenced this issue Feb 25, 2022
@aeneasr
refactor: update apple and microsoft config key names
5840542 
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose:

```patch
- private_key_id
+ apple_private_key_id

- private_key
+ apple_private_key

- team_id
+ apple_team_id

- tenant
+ microsoft_tenant
```

Closes #1979
aeneasr added a commit that referenced this issue Feb 25, 2022
@aeneasr
refactor: update apple and microsoft config key names (#2261)
6da2370 
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose:

```patch
- private_key_id
+ apple_private_key_id

- private_key
+ apple_private_key

- team_id
+ apple_team_id

- tenant
+ microsoft_tenant
```

Closes #1979
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
@aeneasr
refactor: update apple and microsoft config key names (ory#2261)
d3c7c9c 
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose:

```patch
- private_key_id
+ apple_private_key_id

- private_key
+ apple_private_key

- team_id
+ apple_team_id

- tenant
+ microsoft_tenant
```

Closes ory#1979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
feat New feature or request.
Projects
None yet
Milestone
v0.9.0-alpha.1
Development

Successfully merging a pull request may close this issue.

refactor: update apple and microsoft config key names ory/kratos
1 participant
@aeneasr