Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resumable session is not cleared up on error #2016

Closed
6 tasks done
aeneasr opened this issue Dec 1, 2021 · 0 comments · Fixed by #2123 or #2131
Closed
6 tasks done

Resumable session is not cleared up on error #2016

aeneasr opened this issue Dec 1, 2021 · 0 comments · Fixed by #2123 or #2131
Assignees
@aeneasr
Labels
bug Something is not working.
Milestone
v0.8.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Dec 1, 2021

Preflight checklist

Describe the bug

When signing in using OIDC it can happen that a stale resumable session is in the browser's store. It will cause the sign in flow to fail.

Reproducing the bug

Not sure yet - I believe the problem was cookie confusion as the user had two cookies for resumable sessions available.

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

Ory Cloud

In which environment are you deploying?

No response

Additional Context

Reported by @sashatalalasha
@aeneasr aeneasr added the bug Something is not working. label Dec 1, 2021
@aeneasr aeneasr self-assigned this Dec 1, 2021
@aeneasr aeneasr added this to the v0.8.0-alpha.1 milestone Dec 1, 2021
aeneasr added a commit that referenced this issue Jan 8, 2022
@aeneasr
fix(continuity): properly reset cookies that became invalid
12f1306 
Resolves several reports related to incorrect handling of invalid continuity issues.

Closes #2121
Closes ory-corp/cloud#1786
Closes #2016
Potentially #2108
@aeneasr aeneasr mentioned this issue Jan 8, 2022
Merged
7 tasks
aeneasr added a commit that referenced this issue Jan 8, 2022
@aeneasr
fix(continuity): properly reset cookies that became invalid
edc3da4 
Resolves several reports related to incorrect handling of invalid continuity issues.

Closes #2121
Closes ory-corp/cloud#1786
Closes #2016
Potentially #2108
aeneasr added a commit that referenced this issue Jan 8, 2022
@aeneasr
fix(continuity): properly reset cookies that became invalid
8e4b4fb 
Resolves several reports related to incorrect handling of invalid continuity issues.

Closes #2121
Closes ory-corp/cloud#1786
Closes #2016
Potentially #2108
aeneasr added a commit that referenced this issue Jan 10, 2022
@aeneasr
fix: add ability to resume continuity sessions from several cookies
406eb47 
Closes #2016
Closes #1786
Closes ory-corp/cloud#1786
Closes #2108
@aeneasr aeneasr mentioned this issue Jan 10, 2022
Merged
7 tasks
aeneasr added a commit that referenced this issue Jan 10, 2022
@aeneasr
fix: add ability to resume continuity sessions from several cookies
cbffde4 
Closes #2016
Closes #1786
Closes ory-corp/cloud#1786
Closes #2108
aeneasr added a commit that referenced this issue Jan 10, 2022
@aeneasr
fix: add ability to resume continuity sessions from several cookies (#…
8b87bdb 
…2131)

Closes #2016
Closes #1786
Closes ory-corp/cloud#1786
Closes #2108
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
@aeneasr
fix(continuity): properly reset cookies that became invalid
5258fa8 
Resolves several reports related to incorrect handling of invalid continuity issues.

Closes ory#2121
Closes ory-corp/cloud#1786
Closes ory#2016
Potentially ory#2108
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
@aeneasr
fix: add ability to resume continuity sessions from several cookies (o…
2b521e0 
…ry#2131)

Closes ory#2016
Closes ory#1786
Closes ory-corp/cloud#1786
Closes ory#2108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working.
Projects
None yet
Milestone
v0.8.0-alpha.1
1 participant
@aeneasr