Wrong ID used for TOTP secret label

[UncleSamSwiss]

Preflight checklist

• I could not find a solution in the existing issues, docs, nor discussions.
• I agree to follow this project's Code of Conduct.
• I have read and am following this repository's Contribution Guidelines.
• This issue affects my Ory Cloud project.
• I have joined the Ory Community Slack.
• I am signed up to the Ory Security Patch Newsletter.

Describe the bug

The message ID used in NewInfoSelfServiceSettingsTOTPSecretLabel() should in my opinion be InfoSelfServiceSettingsTOTPSecretLabel and not InfoSelfServiceSettingsTOTPSecret. Otherwise the same ID is used for the label as well as for the content.

See here:

kratos/text/message_settings.go

Line 40 in 61ce3c0

ID: InfoSelfServiceSettingsTOTPSecret,

The variable is already used above:

kratos/text/message_settings.go

Line 30 in 61ce3c0

ID: InfoSelfServiceSettingsTOTPSecret,

Reproducing the bug

I guess you could try to retrieve the TOTP settings and you would see the structure using twice the same ID. (Not tested).

Relevant log output

No response

Relevant configuration

No response

Version

0.8.2-alpha.1, but still valid on master

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

[UncleSamSwiss]

Besides the above mentioned bug, I found the following other issues in the message ID code. If you prefer, I can open separate issues for each of them.

• Add/remove security key use the same ID (InfoSelfServiceSettingsRegisterWebAuthn):
  

  kratos/text/message_settings.go

  Lines 156 to 162 in 61ce3c0

  	func NewInfoSelfServiceRegisterWebAuthn() *Message {
  	return &Message{
  	ID: InfoSelfServiceSettingsRegisterWebAuthn,
  	Text: "Add security key",
  	Type: Info,
  	}
  	}

  
  and
  

  kratos/text/message_settings.go

  Lines 172 to 182 in 61ce3c0

  	func NewInfoSelfServiceRemoveWebAuthn(name string, createdAt time.Time) *Message {
  	return &Message{
  	ID: InfoSelfServiceSettingsRegisterWebAuthn,
  	Text: fmt.Sprintf("Remove security key \"%s\"", name),
  	Type: Info,
  	Context: context(map[string]interface{}{
  	"display_name": name,
  	"added_at": createdAt,
  	}),
  	}
  	}

• Two backup recovery code messages use the same ID (ErrorValidationLookupAlreadyUsed):
  

  kratos/text/message_validation.go

  Lines 89 to 105 in 61ce3c0

  	func NewErrorValidationLookupAlreadyUsed() *Message {
  	return &Message{
  	ID: ErrorValidationLookupAlreadyUsed,
  	Text: "This backup recovery code has already been used.",
  	Type: Error,
  	Context: context(nil),
  	}
  	}
  	func NewErrorValidationLookupInvalid() *Message {
  	return &Message{
  	ID: ErrorValidationLookupAlreadyUsed,
  	Text: "The backup recovery code is not valid.",
  	Type: Error,
  	Context: context(nil),
  	}
  	}