Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add IssuerURL for Apple ID #2565

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Urbansson
Copy link
Contributor

No issuer url was specified when using the Apple ID provider, this forced usersers to manually enter it in the provider config.

This PR adds the Apple ID issuer url to the provider simplifying the setup.

Related issue(s)

Fixes: #2558

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

No issuer url was specified when using the Apple ID provider,
this forced usersers to manually enter it in the provider config.

This PR adds the Apple ID issuer url to the provider simplifying the setup.
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 2aeb0a2 into ory:master Jul 4, 2022
@vinckr
Copy link
Member

vinckr commented Jul 7, 2022

Hello @Urbansson
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

t-tomalak pushed a commit to Wikia/kratos that referenced this pull request Oct 21, 2022
No issuer url was specified when using the Apple ID provider,
this forced usersers to manually enter it in the provider config.

This PR adds the Apple ID issuer url to the provider simplifying the setup.
harnash added a commit to Wikia/kratos that referenced this pull request Oct 21, 2022
fix: add issuerURL for apple id (ory#2565)
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
No issuer url was specified when using the Apple ID provider,
this forced usersers to manually enter it in the provider config.

This PR adds the Apple ID issuer url to the provider simplifying the setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign in with Apple ID - unsupported protocol scheme.
3 participants