-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement endpoint for invalidating all sessions for a given identity #1740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
+ Coverage 73.94% 74.10% +0.16%
==========================================
Files 260 260
Lines 12701 12714 +13
==========================================
+ Hits 9392 9422 +30
+ Misses 2682 2667 -15
+ Partials 627 625 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen #655? It covers your use case as well. Just FYI and for linking this PR to that issue.
Not too happy about the path of the endpoint, but don't have a better idea right now 😅
Oh. I've missed that. Thanks!
Yeah. I would choose something more appropriate but moving it to |
Co-authored-by: Patrik <[email protected]>
Co-authored-by: Patrik <[email protected]>
Co-authored-by: Patrik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)
Co-authored-by: hackerman <[email protected]>
8490734
to
1a3c131
Compare
90787c0
to
ad71d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just one minor thing :)
This PR introduces endpoint to destroy all sessions for a given identity which effectively logouts user from all devices/sessions. This is useful when for some security concern we want to make sure there are no "old" sessions active or other "staff" related actions (such as force logout after password change etc.).
Contributes to #655
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.