fix(selfservice): Recovery self service flow passes on return_to URL

[sawadashota]

Related issue(s)

#914

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security. vulnerability, I
  confirm that I got green light (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[codecov]

Codecov Report

Merging #1920 (6d315bb) into master (29eccd7) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 6d315bb differs from pull request most recent head 341e8b2. Consider uploading reports for the commit 341e8b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   74.93%   74.92%   -0.01%     
==========================================
  Files         293      293              
  Lines       15318    15331      +13     
==========================================
+ Hits        11478    11487       +9     
- Misses       3012     3014       +2     
- Partials      828      830       +2     

Impacted Files	Coverage Δ
selfservice/flow/recovery/handler.go	59.09% <ø> (ø)
selfservice/strategy/link/strategy_recovery.go	63.98% <60.00%> (-0.18%)	⬇️
internal/testhelpers/selfservice_verification.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29eccd7...341e8b2. Read the comment docs.

[sawadashota]

@aeneasr Would you please review this PR?

[aeneasr]

Sorry @sawadashota - I did not have a lot of time these past weeks to review PRs. Can you please add an e2e test for this PR? If you need help, please do let me know :)

[aeneasr]

Looking great, only a few minor requests :))

[aeneasr]

This would incorrectly use the original recovery flow as the request URL. But we only need the return_to query parameter - I would suggest we use only that part!

[sawadashota]

e2e tests failed at profiles/verification/verify but this is also failed at master branch.

@aeneasr I've fixed. Tests for these seem to be passed!

[aeneasr]

🙏

[aeneasr]

Sorry for taking so long to review!