Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add content-type to allowed headers #2015

Merged
merged 2 commits into from
Dec 2, 2021
Merged

docs: Add content-type to allowed headers #2015

merged 2 commits into from
Dec 2, 2021

Conversation

DenisPalnitsky
Copy link
Contributor

It's a documentation update. Cors fails in case when Kratos public is not on the same subdomain as client.
I could be fixed by adding Content-Type to allow headers.
Refer to #1993

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Dec 1, 2021

Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can merge it right away!


Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@DenisPalnitsky
Copy link
Contributor Author

Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can merge it right away!

Done.
Also added the same fix to unversioned docs.

@vinckr vinckr changed the title Add content-type to allowed headers docs: Add content-type to allowed headers Dec 2, 2021
@zepatrik zepatrik merged commit dd890ab into ory:master Dec 2, 2021
@DenisPalnitsky DenisPalnitsky deleted the patch-1 branch December 2, 2021 14:46
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants