feat: buildkit with multi stage build #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stage_build # Conflicts: # .docker/Dockerfile-build
aeneasr
force-pushed
the
buildkit_and_multi_stage_build
branch
from
5728f5d
to
0d28e8c
Compare
mitar
reviewed
Dec 8, 2021
| @@ -1,4 +1,5 @@ | |||
| FROM golang:1.16.10-alpine3.14 AS builder | |||
| FROM golang:1.17-alpine3.15 AS base | |||
| # syntax = docker/dockerfile:1-experimental | |||
There was a problem hiding this comment.
This should be the first line in the file.
There was a problem hiding this comment.
Personally I do not like to use it and instead rely on Docker 20+ already supporting those additional features. The reason why I do not like it is because if you provide it it makes Docker always pull the docker/dockerfile image first, before doing anything else, which delays the build process.
There was a problem hiding this comment.
Looks like this has been merged with the "comment" in the wrong line. This way it does nothing and is very missleading.
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Co-authored-by: abador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1948
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments