Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Send 404 instead of null response for unknown verification flows #2102

Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix: Send 404 instead of null response for unknown verification flows #2102

merged 1 commit into from
Jan 4, 2022

Conversation

meyfa
Copy link
Contributor

@meyfa meyfa commented Jan 4, 2022

Fixes the verification handler to write the error, instead of nil object, when the flow does not exist. Adds tests for every handler to check proper behavior in that regard.

Related issue(s)

Fixes #2099

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

aeneasr
aeneasr approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@aeneasr aeneasr merged commit c9490c8 into ory:master Jan 4, 2022
@meyfa meyfa deleted the fix-2099 branch January 4, 2022 11:03
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@meyfa
fix: send 404 instead of null response for unknown verification flows (…
78511fe 
…ory#2102)

Fixes the verification handler to write the error, instead of nil object, when the flow does not exist. Adds tests for every handler to check proper behavior in that regard.

Closes ory#2099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetching invalid verification flow returns 200 OK with null body
2 participants
@meyfa @aeneasr