Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove notice importing credentials not possible api doc #2418

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Apr 22, 2022

  • docs: remove notice importing credentials not possible

I tested with make sdk and looked as expected.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@vinckr vinckr changed the title update api doc docs: update api doc Apr 22, 2022
@vinckr vinckr changed the title docs: update api doc docs: remove notice importing credentials not possible api doc Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2418 (e7b15a7) into master (638d45c) will increase coverage by 0.07%.
The diff coverage is 50.00%.

❗ Current head e7b15a7 differs from pull request most recent head e03056d. Consider uploading reports for the commit e03056d to get more accurate results

@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   76.39%   76.46%   +0.07%     
==========================================
  Files         316      318       +2     
  Lines       17404    17150     -254     
==========================================
- Hits        13296    13114     -182     
+ Misses       3171     3099      -72     
  Partials      937      937              
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_apple.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_discord.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_facebook.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_github.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_github_app.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_microsoft.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_slack.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_spotify.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_vk.go 0.00% <ø> (ø)
selfservice/strategy/oidc/provider_yandex.go 0.00% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562e340...e03056d. Read the comment docs.

@aeneasr aeneasr merged commit b80ed69 into master Apr 22, 2022
@aeneasr aeneasr deleted the update-api-doc branch April 22, 2022 14:36
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants