Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marshalled session state #2901

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix: marshalled session state #2901

merged 2 commits into from
Nov 18, 2022

Conversation

kelkarajay
Copy link
Contributor

  • Use .isActive() eval for state

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #2901 (a98f0d1) into master (56feb07) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
- Coverage   76.11%   76.08%   -0.04%     
==========================================
  Files         308      308              
  Lines       18873    18880       +7     
==========================================
- Hits        14366    14364       -2     
- Misses       3389     3397       +8     
- Partials     1118     1119       +1     
Impacted Files Coverage Δ
session/session.go 76.98% <71.42%> (-0.33%) ⬇️
cmd/courier/watch.go 63.01% <0.00%> (-9.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit bcbf68e into master Nov 18, 2022
@aeneasr aeneasr deleted the fix/session-listing branch November 18, 2022 14:00
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants