Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin nancy #2977

Merged
merged 1 commit into from
Dec 29, 2022
Merged

chore: pin nancy #2977

merged 1 commit into from
Dec 29, 2022

Conversation

CaptainStandby
Copy link
Contributor

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

github-actions[bot]
github-actions bot previously approved these changes Dec 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.94 | [dashboard]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.94 | [dashboard]

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #2977 (023f20a) into master (131b8c5) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 023f20a differs from pull request most recent head be99f68. Consider uploading reports for the commit be99f68 to get more accurate results

@@            Coverage Diff             @@
##           master    #2977      +/-   ##
==========================================
- Coverage   76.16%   76.14%   -0.03%     
==========================================
  Files         309      309              
  Lines       19074    19074              
==========================================
- Hits        14528    14524       -4     
- Misses       3421     3424       +3     
- Partials     1125     1126       +1     
Impacted Files Coverage Δ
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr
Copy link
Contributor

alnr commented Dec 28, 2022

LGTM, ready to merge?

@aeneasr aeneasr marked this pull request as ready for review December 29, 2022 08:35
@aeneasr aeneasr merged commit 20da533 into master Dec 29, 2022
@aeneasr aeneasr deleted the hf-pin-nancy branch December 29, 2022 08:36
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants