Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing SessionIssued event for api flows #3348

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Jun 26, 2023
@jonas-jonas jonas-jonas changed the title fix: missing SessionIssued event for api flows fix: add missing SessionIssued event for api flows Jun 26, 2023
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on this quickly! Not sure if we hit all places yet, though.

selfservice/flow/login/hook.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3348 (efbb7f1) into master (b2ecb10) will decrease coverage by 0.01%.
The diff coverage is 92.00%.

❗ Current head efbb7f1 differs from pull request most recent head d41c142. Consider uploading reports for the commit d41c142 to get more accurate results

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
- Coverage   78.04%   78.04%   -0.01%     
==========================================
  Files         324      324              
  Lines       21013    21021       +8     
==========================================
+ Hits        16400    16406       +6     
- Misses       3384     3385       +1     
- Partials     1229     1230       +1     
Impacted Files Coverage Δ
driver/config/config.go 82.94% <ø> (ø)
driver/factory.go 57.69% <ø> (ø)
persistence/sql/persister_session.go 84.37% <60.00%> (-0.55%) ⬇️
persistence/sql/identity/persister_identity.go 80.03% <100.00%> (ø)
selfservice/flow/login/hook.go 86.61% <100.00%> (+0.38%) ⬆️

@aeneasr
Copy link
Member

aeneasr commented Jun 26, 2023

I agree that this is not very well instrumented yet. The instrumentation should probably happen in the persister. We can merge this as is though IMO. Up to you @jonas-jonas . Also possible that we missed a few spots for example in social sign in

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hperl hperl merged commit adf78e0 into master Jun 26, 2023
@hperl hperl deleted the jonas-jonas/fixMissingSessionIssuedEvent branch June 26, 2023 17:53
@aeneasr
Copy link
Member

aeneasr commented Jun 27, 2023

#3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants