Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change return urls in quickstarts #3928

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: change return urls in quickstarts #3928

merged 1 commit into from
May 21, 2024

Conversation

jacwil
Copy link
Contributor

@jacwil jacwil commented May 19, 2024

Change the default return url for Quickstarts to welcome page instead of site root.

Related issue(s)

Issue: Sign In redirects to root page of the self service ui.

More context: The Kratos SelfService UI used by the Quickstarts does not serve a root page but instead returns a json error: {"error":{"code":404,"status":"Not Found","message":"Requested url does not match any rules"}}.

Steps to reproduce:

  1. Start Kratos and Oathkeeper. Example: docker compose -f quickstart.yml -f quickstart-oathkeeper.yml up --build --force-recreate
  2. Go to the welcome page and then Sign Up.
  3. Upon completing account creation you are redirected to site root and presented with the json "Not Found" error.
  4. Go to the welcome page after creating an account and Sign Out.
  5. Go to the welcome page and Sign In. Upon successful sign in you are redirected to site root and presented with the json "Not Found" error.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aeneasr aeneasr merged commit 9730e09 into ory:master May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants