Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judge: copy all request headers #133

Closed
wants to merge 1 commit into from

Conversation

lsjostro
Copy link
Contributor

@lsjostro lsjostro commented Nov 5, 2018

Signed-off-by: Lars Sjöström [email protected]

Related issue

When running oathkeeper in judge mode, it should pass on all request headers. Especially useful when using credential issuer header module for passing headers down stream.

Proposed changes

Not just copy the Authorization header but copy all request headers.

Checklist

  • [x ] I have read the contributing guidelines
  • [ x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • [x ] I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Signed-off-by: Lars Sjöström <[email protected]>
@lsjostro
Copy link
Contributor Author

lsjostro commented Nov 5, 2018

Oops didn't see #120 which more or less the same thing. I think it more generic to just copy everything though.

@aeneasr
Copy link
Member

aeneasr commented Nov 5, 2018

I have to revisit this with a bit of time. I'm not entirely sure how r is being propagated throughout the request. I'm also not sure if just copying everything is what we want here. It's on my to-do list for this week!

@ngerstle-cognite
Copy link

This (or #120 ) would be very helpful when using oathkeeper with ambassador for enriching incoming requests with relevant user information.
Any chance of some forward movement?

@aeneasr
Copy link
Member

aeneasr commented Jan 8, 2019

Yeah, has been in the back of my mind for a while now. I'll bump it in priority!

aeneasr added a commit that referenced this pull request Apr 6, 2019
@aeneasr aeneasr closed this in #169 Apr 6, 2019
aeneasr added a commit that referenced this pull request Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants