Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Add credentials issuers headers to /judge responses. #120

Closed
wants to merge 1 commit into from

Conversation

jfardello
Copy link

Signed-off-by: José Fardello [email protected]

This PR adds credentials issuers headers for /judge, while the handler_test passes, I did not include any test.. I can't figure out how to properly configure NewCredentialsIssuerHeaders() in order to test this.

@aeneasr
Copy link
Member

aeneasr commented Sep 23, 2018

Thank you for the contribution! I definitely understand the approach but am thinking if there is a better way to approach this. I'll let you know once I have some ideas. By the way, we should also do this for the cookie credential issuer!

@lsjostro lsjostro mentioned this pull request Nov 5, 2018
3 tasks
@ngrigoriev
Copy link
Contributor

I am wondering if it is possible to integrate this into Oathkeeper. The lack of this feature prevents me from using it with Ambassador API Gateway.

@aeneasr
Copy link
Member

aeneasr commented Apr 5, 2019

Yeah, I'll work on this over the weekend!

aeneasr added a commit that referenced this pull request Apr 6, 2019
@aeneasr aeneasr closed this in #169 Apr 6, 2019
aeneasr added a commit that referenced this pull request Apr 6, 2019
@ngrigoriev
Copy link
Contributor

Thanks! About to try it from master. Any chances of new Oathkeeper release any time soon? ;)

@ngrigoriev
Copy link
Contributor

@aeneasr tested - works like charm, thanks again!

@aeneasr
Copy link
Member

aeneasr commented Apr 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants