Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default logic if header is Authorization #311

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

pike1212
Copy link
Contributor

@pike1212 pike1212 commented Dec 16, 2019

Related issue

#308

Proposed changes

If Authorization header matches default value, then use the same default logic

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the
    developer guide (if appropriate)

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2019

That looks great! Could you also please add a test that covers this? That way we make sure we don't introduce this issue again later. :)

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2019

Rerunning tests because of a flaky test failure

@aeneasr aeneasr merged commit 464fa31 into ory:master Dec 17, 2019
pike1212 added a commit to pike1212/oathkeeper that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants