Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose cleanup #325

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Docker compose cleanup #325

merged 2 commits into from
Mar 2, 2020

Commits on Feb 16, 2020

  1. Docker: add 'Dockerfile-dc' to build docker image for Docker Compose 

    Add a new file 'Dockerfile-dc' which will primarily be used by Docker Compose to
build docker images. Unlike the existing Dockerfile which depends on the Makefile
to build the binary, this Dockerfile copies the source code and builds the
binary.

Copied from: https://github.com/ory/kratos/blob/master/.docker/Dockerfile

Signed-off-by: karthik nayak <[email protected]>
    @KarthikNayak
    KarthikNayak committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    765159b View commit details
    Browse the repository at this point in the history

  2. Docker: update the Docker Compose file as per changes made over time 

    Oathkeeper has gone through a couple of changes since the initial draft of the
docker compose file, considering these changes and the newly introduced
Dockerfile in the previous commit, make these changes to the docker-compose.yml:
1. Bump the version of the compose file to 3.
2. Remove the need for the postgres database app, since Oathkeeper no longer needs a
database.
3. Remove the need for the migration app, since we no longer need to migrate since
there is no database and the option is deprecated.
4. Use the newly defined Dockerfile 'Dockerfile-dc'.
5. We now serve both API and PROXY from the same app, so we don't need two
instances of the app.
6. Add sample config, rules and JWK files to `.docker_compose`, mount this via a
volume mount.

Signed-off-by: karthik nayak <[email protected]>
    @KarthikNayak
    KarthikNayak committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    99810d6 View commit details
    Browse the repository at this point in the history