Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Read windows path error - 2 #557

Merged
merged 34 commits into from
Nov 18, 2020
Merged

fix: Read windows path error - 2 #557

merged 34 commits into from
Nov 18, 2020

Commits on Oct 15, 2020

  1. fix: file urls doesn't work in Windows

    @PatrLind
    PatrLind committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    59f3d80 View commit details
    Browse the repository at this point in the history

  2. Fixes so that file urls work for jwks_url

    @PatrLind
    PatrLind committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    04ad034 View commit details
    Browse the repository at this point in the history

  3. Tests didn't run correctly when using an incorrect int to string conv… 

    …ersion
    @PatrLind
    PatrLind committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7635fbd View commit details
    Browse the repository at this point in the history

  4. Added non standard windows path case to make tests not fail

    @PatrLind
    PatrLind committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    ab0fadf View commit details
    Browse the repository at this point in the history

  5. Makes the test not fail on Windows

    @PatrLind
    PatrLind committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    cdcba08 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Move from package helper to x

    @PatrLind
    PatrLind committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    044eaa2 View commit details
    Browse the repository at this point in the history

  2. Removes support for hostname and adds special handling of all non sta… 

    …ndard variants of file URLs
    @PatrLind
    PatrLind committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c4d5b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. ci: add windows unit tests

    @zepatrik
    zepatrik committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    98c91ca View commit details
    Browse the repository at this point in the history

  2. ci: enable windows unit tests

    @zepatrik
    zepatrik committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    4262cd0 View commit details
    Browse the repository at this point in the history

  3. ci: run windows test as github workflow instead of CCI

    @zepatrik
    zepatrik committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    f43a989 View commit details
    Browse the repository at this point in the history

  4. ci: escape * in yaml

    @zepatrik
    zepatrik committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    8c1d4ab View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Merge pull request #1 from ory/windows-ci-test 

    ci: windows unit test
    @PatrLind
    PatrLind authored Oct 21, 2020
    Configuration menu
    Copy the full SHA
    ec676bf View commit details
    Browse the repository at this point in the history

  2. New ParseURL function and fixes to GetURLFilePath 

    The PatseURL function will handle parsing URLs with special handling of file:// URLs
The updated GetURLFilePath function will return a correct path baed on the updated URL parsing.
    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    1360892 View commit details
    Browse the repository at this point in the history

  3. Fox compile error, TestGetURLFilePath expects ptr

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    6dbdf82 View commit details
    Browse the repository at this point in the history

  4. Add ParseOrPanic from xurl

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    91352a2 View commit details
    Browse the repository at this point in the history

  5. Only handle UNC paths on Windows

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    933e376 View commit details
    Browse the repository at this point in the history

  6. interpret empty scheme as file

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    0d489b3 View commit details
    Browse the repository at this point in the history

  7. Use the fixed URL parse function

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    0c5070c View commit details
    Browse the repository at this point in the history

  8. Use the fixed URL parse helpers

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    2936897 View commit details
    Browse the repository at this point in the history

  9. Fixes handling of files with ./ path

    @PatrLind
    PatrLind committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    9a24f01 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Restore TestFetcherWatchRepositoryFromFS file path

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    d2b25ce View commit details
    Browse the repository at this point in the history

  2. Fix for windows paths and tripple slash file URLs

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    09f5e3d View commit details
    Browse the repository at this point in the history

  3. Skip TestFetcherWatchRepositoryFromKubernetesConfigMap on Windows

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    aea51bd View commit details
    Browse the repository at this point in the history

  4. Check for empty scheme and clean file path

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    f025b0b View commit details
    Browse the repository at this point in the history

  5. Update x/fileurl.go 

    strings.Index() == 0 -> strings.HasPrefix()

Co-authored-by: Patrik <[email protected]>
    @PatrLind @zepatrik
    PatrLind and zepatrik authored Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a94d262 View commit details
    Browse the repository at this point in the history

  6. Update x/fileurl.go 

    Namingconvention

Co-authored-by: Patrik <[email protected]>
    @PatrLind @zepatrik
    PatrLind and zepatrik authored Oct 22, 2020
    Configuration menu
    Copy the full SHA
    940878e View commit details
    Browse the repository at this point in the history

  7. Fixes after suggestions from zepatrik 

    Also fixed a few issues with \ on POSIX where it should not be interpreted as a path separator.
    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    9c61d60 View commit details
    Browse the repository at this point in the history

  8. Small cleanup

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    fa70665 View commit details
    Browse the repository at this point in the history

  9. Removed unused function stripFistPathSeparators

    @PatrLind
    PatrLind committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    69aa394 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Improved readability 

    I added a trimPrefixIC function to improve the readability of the code.
Also removed some unessesary code
    @PatrLind
    PatrLind committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7a70e0c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Merge remote-tracking branch 'remotes/ory/master' into master

    @PatrLind
    PatrLind committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9ec4ad2 View commit details
    Browse the repository at this point in the history

  2. Updated to github.com/ory/x v0.0.163

    @PatrLind
    PatrLind committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    5a96ab4 View commit details
    Browse the repository at this point in the history

  3. Switched to github.com/ory/x/urlx 

    The code is now in urlx, I changed the ParseOrXXX functions to use urlx.Parse() instead of url.Parse() as it still is in urlx.
    @PatrLind
    PatrLind committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a451fc7 View commit details
    Browse the repository at this point in the history

  4. go mod tidy

    @PatrLind
    PatrLind committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ba2970f View commit details
    Browse the repository at this point in the history