-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add request header in match context #719
Conversation
proxy/request_handler_test.go
Outdated
@@ -491,6 +496,7 @@ func TestInitializeSession(t *testing.T) { | |||
RegexpCaptureGroups: []string{"user"}, | |||
URL: x.ParseURLOrPanic("http://localhost/user"), | |||
Method: "GET", | |||
Header: newTestHeader(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think for expected results better to use constant / or literal instead of function
@aeneasr can you plz review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this looks great and sorry for the late review - last week was hectic :)
Could you please also update the documentation in docs/docs
on this? Thank you!
Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:
Thank you! |
Hmmm...why isn't the pipeline triggering -.- |
@aeneasr can you figure out why the windows go test is failing? |
Yeah it's not your fault! |
But Unfortunately, for some reason, the CircleCI tests are not running. Do you maybe follow your/a fork of this repository on CircleCI? If so, you need to unsubscribe / unwatch from that CircleCI project. Then, make another push to your branch using:
That should get the CI running! Thank you :) |
@aeneasr I think you need to approve something somewhere to kick off the tests. |
@aeneasr can you look into this |
Hey there, sorry for the long delay - yesterday was a holiday :) I've approved the run. I've also create a post on GH community regarding this as the current approval behavior is so annoying. |
Hm no, this looks like a circle ci issue. I'll run the tests locally |
Awesome, thank you! 🎉 Your contribution makes Ory better :) |
Related issue
#512
Proposed changes
After wasting a lot of time on why I'm not able to use Headers within the Remote Authorizer, I found out that Oathkeeper isn't setting the Headers while initializing the AuthenticationSession. We use Remote Authorizer and pass on some key information through headers only & without this fix, we can't use Oathkeeper at all, so setting the request headers inside MatchContext.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
See this PR -> #718