Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "lookup_secret" enum value in SDK #147

Closed
4 of 6 tasks
roboptics opened this issue Feb 10, 2022 · 0 comments · Fixed by ory/kratos#2223
Closed
4 of 6 tasks

Missing "lookup_secret" enum value in SDK #147

roboptics opened this issue Feb 10, 2022 · 0 comments · Fixed by ory/kratos#2223
Labels
bug Something is not working.

Comments

@roboptics
Copy link

Preflight checklist

Describe the bug

For SDK languages (other than GO) the "lookup_secret" enum value is missing. For .NET, the full name of the enum where this value is missing is:

Ory.Client.Model.ClientSessionAuthenticationMethod.MethodEnum

This issue causes the deserialization of Ory.Client.Model.ClientSession to fail, which prevents login submission and fetching client session from working when this authentication method is used.

Below are SDK source files where the "lookup_secret" enum value is missing:

https://github.com/ory/sdk/blob/master/clients/kratos/java/src/main/java/sh/ory/kratos/model/SessionAuthenticationMethod.java

https://github.com/ory/sdk/blob/master/clients/kratos/php/lib/Model/SessionAuthenticationMethod.php

https://github.com/ory/sdk/blob/master/clients/kratos/dotnet/src/Ory.Kratos.Client/Model/KratosSessionAuthenticationMethod.cs

Reproducing the bug

Just confirm that the "lookup_secret" enum value is missing from the SDK languages in description.

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

@roboptics roboptics added the bug Something is not working. label Feb 10, 2022
aeneasr added a commit to ory/kratos that referenced this issue Feb 14, 2022
aeneasr added a commit to ory/kratos that referenced this issue Feb 14, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant