Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sensitive log value redaction text configurable #482

Merged
merged 1 commit into from
Mar 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions configx/stub/from-files/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,11 @@
"title": "Leak Sensitive Log Values",
"description": "If set will leak sensitive values (e.g. emails) in the logs."
},
"redaction_text": {
"type": "string",
"title": "Sensitive log value redaction text",
"description": "Text to use, when redacting sensitive log value."
},
"format": {
"type": "string",
"enum": [
Expand Down
5 changes: 5 additions & 0 deletions configx/stub/hydra/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,11 @@
"description": "Logs sensitive values such as cookie and URL parameter.",
"default": false
},
"redaction_text": {
"type": "string",
"title": "Sensitive log value redaction text",
"description": "Text to use, when redacting sensitive log value."
},
"format": {
"type": "string",
"description": "Sets the log format.",
Expand Down
5 changes: 5 additions & 0 deletions configx/stub/kratos/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,11 @@
"title": "Leak Sensitive Log Values",
"description": "If set will leak sensitive values (e.g. emails) in the logs."
},
"redaction_text": {
"type": "string",
"title": "Sensitive log value redaction text",
"description": "Text to use, when redacting sensitive log value."
},
"format": {
"type": "string",
"enum": [
Expand Down
5 changes: 5 additions & 0 deletions configx/stub/multi/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,11 @@
"title": "Leak Sensitive Log Values",
"description": "If set will leak sensitive values (e.g. emails) in the logs."
},
"redaction_text": {
"type": "string",
"title": "Sensitive log value redaction text",
"description": "Text to use, when redacting sensitive log value."
},
"format": {
"type": "string",
"enum": [
Expand Down
5 changes: 5 additions & 0 deletions logrusx/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
"title": "Leak Sensitive Log Values",
"description": "If set will leak sensitive values (e.g. emails) in the logs.",
"default": false
},
"redaction_text": {
"type": "string",
"title": "Sensitive log value redaction text",
"description": "Text to use, when redacting sensitive log value."
}
},
"additionalProperties": false
Expand Down
3 changes: 2 additions & 1 deletion logrusx/helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
type Logger struct {
*logrus.Entry
leakSensitive bool
redactionText string
opts []Option
name string
version string
Expand Down Expand Up @@ -171,7 +172,7 @@ func (l *Logger) maybeRedact(value interface{}) interface{} {
return nil
}
if !l.leakSensitive {
return `Value is sensitive and has been redacted. To see the value set config key "log.leak_sensitive_values = true" or environment variable "LOG_LEAK_SENSITIVE_VALUES=true".`
return l.redactionText
}
return value
}
Expand Down
9 changes: 9 additions & 0 deletions logrusx/logrus.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type (
reportCaller bool
exitFunc func(int)
leakSensitive bool
redactionText string
hooks []logrus.Hook
c configurator
}
Expand Down Expand Up @@ -167,6 +168,12 @@ func LeakSensitive() Option {
}
}

func RedactionText(text string) Option {
return func(o *options) {
o.redactionText = text
}
}

func (c *nullConfigurator) Bool(_ string) bool {
return false
}
Expand All @@ -192,6 +199,7 @@ func New(name string, version string, opts ...Option) *Logger {
name: name,
version: version,
leakSensitive: o.leakSensitive || o.c.Bool("log.leak_sensitive_values"),
redactionText: stringsx.DefaultIfEmpty(o.redactionText, `Value is sensitive and has been redacted. To see the value set config key "log.leak_sensitive_values = true" or environment variable "LOG_LEAK_SENSITIVE_VALUES=true".`),
Entry: newLogger(o.l, o).WithFields(logrus.Fields{
"audience": "application", "service_name": name, "service_version": version}),
}
Expand All @@ -203,6 +211,7 @@ func NewAudit(name string, version string, opts ...Option) *Logger {

func (l *Logger) UseConfig(c configurator) {
l.leakSensitive = l.leakSensitive || c.Bool("log.leak_sensitive_values")
l.redactionText = stringsx.DefaultIfEmpty(c.String("log.redaction_text"), l.redactionText)
o := newOptions(append(l.opts, WithConfigurator(c)))
setLevel(l.Entry.Logger, o)
setFormatter(l.Entry.Logger, o)
Expand Down
13 changes: 13 additions & 0 deletions logrusx/logrus_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ func TestTextLogger(t *testing.T) {
l.WithRequest(fakeRequest).Error("An error occurred.")
},
},
{
l: New("logrusx-app", "v0.0.0", ForceFormat("text"), ForceLevel(logrus.TraceLevel), RedactionText("redacted")),
expect: []string{"logrus_test.go", "logrusx_test.TestTextLogger",
"audience=application", "service_name=logrusx-app", "service_version=v0.0.0",
"An error occurred.", "headers:map[", "accept:application/json", "accept-encoding:gzip",
"user-agent:Go-http-client/1.1", "x-request-id:id1234", "host:127.0.0.1:63232", "method:GET",
"query:redacted",
},
notExpect: []string{"testing.tRunner", "bar=foo"},
call: func(l *Logger) {
l.WithRequest(fakeRequest).Error("An error occurred.")
},
},
{
l: New("logrusx-server", "v0.0.1", ForceFormat("text"), LeakSensitive(), ForceLevel(logrus.DebugLevel)),
expect: []string{
Expand Down
8 changes: 8 additions & 0 deletions stringsx/default.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package stringsx

func DefaultIfEmpty(s string, defaultValue string) string {
if len(s) == 0 {
return defaultValue
}
return s
}
12 changes: 12 additions & 0 deletions stringsx/default_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package stringsx

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestDefaultIfEmpty(t *testing.T) {
assert.Equal(t, DefaultIfEmpty("", "default"), "default")
assert.Equal(t, DefaultIfEmpty("custom", "default"), "custom")
}