viperx: Added viper BindEnvsToSchema helper #85
Conversation
viperx/bind_env.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| return viper.BindEnv(keys...) |
There was a problem hiding this comment.
As I noted previously this usage of BindEnv is incorrect: this function does not accept multiple keys https://github.com/spf13/viper/blob/master/viper.go#L960 It either accepts one parameter (the key) or two parameters (the key and the corresponding ENV_VAR_NAME)
There was a problem hiding this comment.
Also, how do we deal with the env names? I guess with the effect of SetEnvKeyReplacer it will work automatically, so afterviper.BindEnv("foo.bar.baz") env FOO_BAR_BAZ should work, right?
There was a problem hiding this comment.
Ah, thanks, I overlooked that completely. Fixed and added a test to make sure this works properly.
Also, how do we deal with the env names? I guess with the effect of SetEnvKeyReplacer it will work automatically, so afterviper.BindEnv("foo.bar.baz") env FOO_BAR_BAZ should work, right?
Exactly!
See ory/oathkeeper#280
See ory/oathkeeper#279
See ory/oathkeeper#276
See ory/oathkeeper#270