This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
fixes for slack API #143
Open
fixes for slack API #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishaan28malik
approved these changes
Jul 29, 2019
os
reviewed
Feb 9, 2020
| @@ -187,8 +187,8 @@ def admin(self): | |||
| def info(self, user): | |||
| return self.get('users.info', params={'user': user}) | |||
|
|
|||
| def list(self, presence=False): | |||
| return self.get('users.list', params={'presence': int(presence)}) | |||
| def list(self, cursor=None, limit=None, presence=False): | |||
There was a problem hiding this comment.
Can you add these two optional parameters at the end? I just want to make sure that we won't break when it's called with positional arguments.
Comment on lines
+372
to
+373
| if thread_ts: | ||
| data['thread_ts'] = thread_ts |
|
@os @Ishaan28malik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple things that are needed to interact with the slack API.