-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bib: bump go to v1.21 and images lib to v0.69.0 #515
Conversation
images v0.69.0 causes the following lint error.
This error was due to the lack of build tags specified to Line 7 in f5e218a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to also update the go version in the Lint & unittests
job, otherwise the runner will use go 1.20 to lint the project. This always results in weird errors like the ones we're seeing (unused imports).
The build flags added in the second commit shouldn't be necessary.
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version. This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758 Signed-off-by: Yohei Ueda <[email protected]>
I updated the Go version in the GitHub workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The konflux job is stuck waiting for approval but I don't see any way to approve it -_- |
Never mind. The PR was just blocked on my previews request for changes. |
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version.
This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758
I created this patch using the following commands.