Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bib: add vhd to supported image types #634

Merged
merged 1 commit into from
Sep 10, 2024
Merged

bib: add vhd to supported image types #634

merged 1 commit into from
Sep 10, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Sep 5, 2024 •
edited
Loading

This is the coresponding change to the images PR [0] that adds
support to build vhd type images directly via bib.

[0] osbuild/images#909

@mvo5 mvo5 mentioned this pull request Sep 5, 2024
Closed
@mvo5 mvo5 force-pushed the add-vhd branch 2 times, most recently from 67ffd95 to 2ad3b81 Compare September 9, 2024 08:24
@mvo5 mvo5 marked this pull request as ready for review September 9, 2024 08:24
achilleas-k
achilleas-k previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ondrejbudai
ondrejbudai previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid, thanks a lot!

@mvo5
Copy link
Collaborator Author

mvo5 commented Sep 9, 2024

It looks like "images" is not happy with "bootc/anaconda-iso" right now and we need to merge osbuild/images#915 first before we merge this one. Sorry for the trouble!

@mvo5 mvo5 dismissed stale reviews from ondrejbudai and achilleas-k September 10, 2024 11:31

The merge-base changed after approval.

@mvo5
bib: add vhd to supported image types
801b4b9 
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
@achilleas-k achilleas-k added this pull request to the merge queue Sep 10, 2024
Merged via the queue into osbuild:main with commit 405808f Sep 10, 2024
8 of 10 checks passed
@henrywang
Copy link
Member

Hi @mvo5, does this vhd can be used by Azure? Thanks.

@mvo5
Copy link
Collaborator Author

mvo5 commented Sep 11, 2024

Hi @mvo5, does this vhd can be used by Azure? Thanks.

Hi @henrywang - yes, my understanding is that this will work with azure, I don't have access to such a machien so couldn't do an end-to-end test but would be interested if it does work there too.

@henrywang
Copy link
Member

Hi @mvo5, does this vhd can be used by Azure? Thanks.

Hi @henrywang - yes, my understanding is that this will work with azure, I don't have access to such a machien so couldn't do an end-to-end test but would be interested if it does work there too.

Thanks! I'm working on vhd image on Azure test now. Will keep you updated.

@pastequo pastequo mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achilleas-k achilleas-k achilleas-k approved these changes

@ondrejbudai ondrejbudai ondrejbudai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvo5 @henrywang @ondrejbudai @achilleas-k