Added strict_mode for CIV. #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narmaku
force-pushed
the
add-strict-mode
branch
3 times, most recently
from
0ee8867
to
f855396
Compare
For this, we refactored the CIVConfig class and changed the behavior to allow overriding config items with cli params. Also, if the config file does not exist, it will always be created with default values and then updated with the values provided via cli params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this, we refactored the CIVConfig class and changed the behavior to allow overriding config items with cli params. Also, if the config file does not exist, it will always be created with default values and then updated with the values provided via cli params.