Add a test to assert on /etc/machine-id permissions for AWS #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@narmaku can you tag a new container version once this is approved and merged ? See https://bugzilla.redhat.com/show_bug.cgi?id=2221269#c6 |
narmaku
reviewed
Aug 9, 2023
narmaku
reviewed
Aug 9, 2023
narmaku
reviewed
Aug 9, 2023
narmaku
reviewed
Aug 9, 2023
narmaku
reviewed
Aug 10, 2023
atodorov
force-pushed
the
assert_on_machine-id
branch
3 times, most recently
from
93c277a
to
f7b5bdd
Compare
narmaku
reviewed
Aug 10, 2023
test_suite/cloud/test_aws.py
Outdated
| @@ -29,6 +29,15 @@ def instance_data_aws_cli(host, instance_data_aws_web): | |||
|
|
|||
| @pytest.mark.order(2) | |||
| class TestsAWS: | |||
| @pytest.mark.pub | |||
There was a problem hiding this comment.
I think we need to remove this marker since if the change will be present during the builds done by Image Builder, the test should be run.
This marker is used to skip the test case in case what's going to be tested only applies to images that are about to be published, or already published (e.g. Bath/Update ad GA image validations). Examples of "pub" test cases are the ones related to rhui.
Related: RHBZ #2221269
atodorov
force-pushed
the
assert_on_machine-id
branch
from
f7b5bdd
to
d6e970a
Compare
atodorov
added a commit
to atodorov/osbuild-composer
that referenced
this pull request
Aug 14, 2023
in order to exercise test for RHBZ#2221269. See: osbuild/cloud-image-val#266
3 tasks
atodorov
added a commit
to atodorov/osbuild-composer
that referenced
this pull request
Aug 14, 2023
in order to exercise test for RHBZ#2221269. See: osbuild/cloud-image-val#266 NOTE: changing more than necessary in order to satisfy CI tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: RHBZ #2221269