tests: tweaks to the way routes are tested #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
commented
Aug 16, 2024
mvo5
force-pushed
the
err-type-ErrServerClosed
branch
7 times, most recently
from
00a1706
to
c2d70b4
Compare
|
Nice improvement ;) |
schuellerf
previously approved these changes
Aug 19, 2024
This commit avoids the hardcoded URL and uses the addr that the echo server is using. This makes it easier to run the tests on a different port. Mostly auto-generated via `sed` (unfortunately some manual tweaking was needed because the coding style is not very consistent).
mvo5
dismissed stale reviews from croissanne, schuellerf, and ezr-ondrej
via
cb493e9
mvo5
force-pushed
the
err-type-ErrServerClosed
branch
from
c2d70b4
to
cb493e9
Compare
|
Meh, sorry, had to force push to fix a conflict, diff is trivial https://github.com/osbuild/image-builder/compare/c2d70b4805738be87ce106ba38cedf68b2bc3a9c..cb493e970114a44e52feb6807a3132195219cade but this will need one more approval now. |
lzap
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: tweak tutil to take
addrandpathinstead of urlThis commit avoids the hardcoded URL and uses the addr that the
echo server is using. This makes it easier to run the tests on
a different port.
Mostly auto-generated via
sed(unfortunately some manual tweakingwas needed because the coding style is not very consistent).