Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use error type ErrServerClosed in test #1304

Merged
merged 1 commit into from
Aug 19, 2024
Merged

server: use error type ErrServerClosed in test #1304

merged 1 commit into from
Aug 19, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 16, 2024 •
edited
Loading

Instead of string comparing use the http.ErrServerClosed when checking for echoServer.Start()

@mvo5
server: use error type ErrServerClosed in test
2e6072e 
Instead of string comparing use the http.ErrServerClosed when
checking for echoServer.Start()
@mvo5 mvo5 marked this pull request as ready for review August 16, 2024 17:18
mgold1234
mgold1234 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mvo5 mvo5 enabled auto-merge (rebase) August 19, 2024 06:20
@mvo5 mvo5 disabled auto-merge August 19, 2024 08:30
@mvo5 mvo5 mentioned this pull request Aug 19, 2024
Merged
@schuellerf
Copy link
Contributor

/retest

@croissanne croissanne merged commit bae14b1 into osbuild:main Aug 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgold1234 mgold1234 mgold1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvo5 @schuellerf @mgold1234 @croissanne