Skip to content

Commit

Permalink
feat: remove signatures in container deployments by default
Browse files Browse the repository at this point in the history
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder/issues/681

Signed-off-by: Miguel Martín <[email protected]>
  • Loading branch information
mmartinv committed Oct 18, 2024
1 parent 1254e47 commit d524795
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/manifest/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func (p *BuildrootFromContainer) serialize() osbuild.Pipeline {
pipeline.Runner = p.runner.String()

image := osbuild.NewContainersInputForSingleSource(p.containerSpecs[0])
stage, err := osbuild.NewContainerDeployStage(image, &osbuild.ContainerDeployOptions{})
stage, err := osbuild.NewContainerDeployStage(image, &osbuild.ContainerDeployOptions{RemoveSignatures: true})
if err != nil {
panic(err)
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/osbuild/container_deploy_stage.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ type ContainerDeployInputs struct {
func (ContainerDeployInputs) isStageInputs() {}

type ContainerDeployOptions struct {
Exclude []string `json:"exclude,omitempty"`
Exclude []string `json:"exclude,omitempty"`
RemoveSignatures bool `json:"remove-signatures,omitempty"`
}

func (ContainerDeployOptions) isStageOptions() {}
Expand Down

0 comments on commit d524795

Please sign in to comment.