Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/otk-gen-partition-table: fix to be wrapped in a "tree" json #890

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Sep 2, 2024

This is similar to #827 but this time for the otk-gen-partition-table which was forgoten in this other PR :(

This is similar to osbuild#827 but
this time for the `otk-gen-partition-table` which was forgoten
in this other PR :(
mvo5 added a commit to mvo5/osbuild-otk that referenced this pull request Sep 2, 2024
This commit updates the example partition table in the
centos-9-x86_64-qcow2.yaml file to "work", i.e. to generate
working otk defines. It is not a complete partition table
yet.

Note that this will need a fix in images to really work:
osbuild/images#890
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@achilleas-k achilleas-k added this pull request to the merge queue Sep 2, 2024
Merged via the queue into osbuild:main with commit b399bd6 Sep 2, 2024
18 checks passed
mvo5 added a commit to mvo5/osbuild-otk that referenced this pull request Sep 2, 2024
This commit updates the example partition table in the
centos-9-x86_64-qcow2.yaml file to "work", i.e. to generate
working otk defines. It is not a complete partition table
yet.

Note that this will need a fix in images to really work:
osbuild/images#890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants