Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/README: describe vendoring modified images repo #3564

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

achilleas-k
Copy link
Member

Add instructions for how to test an updated osbuild/images repo against osbuild-composer and update test manifest generation instructions.

Add instructions for how to test an updated osbuild/images repo against
osbuild-composer.
@achilleas-k achilleas-k requested a review from thozza July 19, 2023 09:49
@bcl
Copy link
Contributor

bcl commented Jul 19, 2023

This should say something about making the replace+vendor change in a separate commit, and not merging it with the replace in place :)

@achilleas-k
Copy link
Member Author

This should say something about making the replace+vendor change in a separate commit, and not merging it with the replace in place :)

Good idea. Updated. Let me know what you think.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ondrejbudai
Copy link
Member

Just a doc update.

@ondrejbudai ondrejbudai merged commit ee0c7b5 into osbuild:main Jul 21, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants