Update osbuild/images #3565
Update osbuild/images #3565
Conversation
achilleas-k
force-pushed
the
vendor/images
branch
2 times, most recently
from
2068da7
to
a6e07f5
Compare
|
Can't figure out where the lint errors are coming from. My local runs aren't showing the errors. EDIT: I accidentally pulled in a newer version of the docker lib that requires go v1.19 and our go mod is for v1.18. I had to do a go build to see the error, because golangci-lint was just showing errors about unused variables and imports instead. |
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
achilleas-k
force-pushed
the
vendor/images
branch
4 times, most recently
from
597e1c4
to
0011f39
Compare
Manifest tests can no longer run and also aren't needed. All image type manifests are generated and built in the obsuild/images CI tests and the test function in images (distro_test_common.TestDistro_Manifest()) has been removed.
achilleas-k
force-pushed
the
vendor/images
branch
from
0011f39
to
4bde8aa
Compare
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
|
|
Update osbuild/images to current main osbuild/images@75be4463a6c2
Remove tests that depended on code that was moved to osbuild/images and has now been removed.
I'm planning to automate this soon, but for now I'm doing it manually because there were breaking changes.
As far as I can tell, automating this with dependabot will require that we do semver releases of the osbuild/images library. It's not a bad idea to have that, so we can control API changes and breakage, but until we stabilise on a few things, I think I'm going to do it manually for a few days.