Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/cloud/gcp/compute: Add SEV_SNP_CAPABLE Guest OS Feature #3579

Merged
merged 2 commits into from
Aug 21, 2023
Merged

internal/cloud/gcp/compute: Add SEV_SNP_CAPABLE Guest OS Feature #3579

merged 2 commits into from
Aug 21, 2023

Conversation

travier
Copy link
Contributor

@travier travier commented Jul 27, 2023

See: coreos/coreos-assembler#3547
See: https://cloud.google.com/blog/products/identity-security/rsa-snp-vm-more-confidential
See: https://issues.redhat.com/browse/COS-2343

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@travier travier mentioned this pull request Jul 27, 2023
Merged
@thozza
Copy link
Member

thozza commented Aug 3, 2023

Hi @travier.

Thanks a lot for the PR. Do you know if all RHEL-9 versions support SNP feature or if it is available only since some specific minor version of RHEL-9?

@thozza thozza self-assigned this Aug 3, 2023
@thozza thozza self-requested a review August 3, 2023 09:18
@thozza
Copy link
Member

thozza commented Aug 3, 2023

I rebased the PR using web UI

@travier
Copy link
Contributor Author

travier commented Aug 7, 2023

Do you know if all RHEL-9 versions support SNP feature or if it is available only since some specific minor version of RHEL-9?

Unfortunately I don't know. I've asked that to the folks that should know 🙂.

@travier
Copy link
Contributor Author

travier commented Aug 7, 2023 •
edited
Loading

From another chat, this is RHEL 9.2 and later only (potentially 9.1 but with lesser support): https://bugzilla.redhat.com/show_bug.cgi?id=2081424

@thozza
Copy link
Member

thozza commented Aug 14, 2023

I added a compatibility case for RHEL-9.0, which does not support SEV-SNP and rebased the PR on top of main. The change looks good from my PoV, but I won't approve since I contributed some code in this PR.

travier
travier commented Aug 14, 2023
View reviewed changes
Copy link
Contributor Author

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thozza thozza enabled auto-merge (rebase) August 14, 2023 15:03
@achilleas-k
Copy link
Member

The installer test on RHEL 8.9 has been causing issues all around lately. I did a rebase to help it along.

@ondrejbudai
Copy link
Member

No failed test related to this change.

@ondrejbudai ondrejbudai merged commit 8ba1976 into osbuild:main Aug 21, 2023
36 checks passed
@travier travier deleted the gcp-sev-snp branch August 23, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achilleas-k achilleas-k achilleas-k approved these changes

@ondrejbudai ondrejbudai ondrejbudai approved these changes

@thozza thozza Awaiting requested review from thozza

@supakeen supakeen Awaiting requested review from supakeen

Assignees

@thozza thozza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@travier @thozza @achilleas-k @ondrejbudai