Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for iot-simplified-installer #3605

Closed
wants to merge 2 commits into from
Closed

Add test case for iot-simplified-installer #3605

wants to merge 2 commits into from

Conversation

yih-redhat
Copy link
Contributor

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@yih-redhat yih-redhat added the WIP Work in progress. Don't run Gitlab CI. label Aug 8, 2023
@achilleas-k achilleas-k added WIP+test Work in progress but run Gitlab CI. WIP Work in progress. Don't run Gitlab CI. and removed WIP Work in progress. Don't run Gitlab CI. WIP+test Work in progress but run Gitlab CI. labels Aug 8, 2023
@achilleas-k achilleas-k self-requested a review August 10, 2023 18:01
@yih-redhat yih-redhat force-pushed the add-iot-test branch 3 times, most recently from 20c6a50 to 1bb67cf Compare August 31, 2023 06:55
@yih-redhat
Copy link
Contributor Author

yih-redhat commented Aug 31, 2023 •
edited
Loading

The latest osbuild-composer on fedora does not have iot-simplified-installer and iot-qcow2-image. But I can build rpm from main branch and then I can see them.

@paulwhalen Tested iot-simplified-installer image(fdo disabled, ignition enabled) on fedora38, still have these two issues:
#3533
#3529

@yih-redhat yih-redhat force-pushed the add-iot-test branch 2 times, most recently from 6c1f8f6 to 4b4c93f Compare August 31, 2023 15:02
@yih-redhat
Copy link
Contributor Author

move iot-qcow2-image test case to pr #3668 , this pr is only for iot-simplified-installer.

@yih-redhat yih-redhat changed the title Add test iot-simplified-installer and iot-qcow2-image Add test case for iot-simplified-installer Aug 31, 2023
@yih-redhat
Copy link
Contributor Author

Tested iot-simplified-installer on fedora 38 and fedora 39, fdo onboarding disabled, firstboot and embeded ignition enabled, works as expected, except known issues.

@yih-redhat yih-redhat force-pushed the add-iot-test branch 3 times, most recently from 7a900c0 to 94ab8d6 Compare September 26, 2023 07:11
achilleas-k
achilleas-k approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achilleas-k
Copy link
Member

There was something strange with the commits in this PR. The second commit was a merge commit and it couldn't be rebased, so I had to amend it. Should be fine now.

achilleas-k
achilleas-k previously approved these changes Sep 29, 2023
View reviewed changes
@achilleas-k achilleas-k enabled auto-merge (rebase) September 29, 2023 12:15
@yih-redhat yih-redhat force-pushed the add-iot-test branch 4 times, most recently from 35900a0 to d840e76 Compare October 8, 2023 06:17
@yih-redhat yih-redhat removed the WIP Work in progress. Don't run Gitlab CI. label Oct 8, 2023
henrywang
henrywang reviewed Oct 8, 2023
View reviewed changes
test/cases/ostree-simplified-installer.sh Outdated
fi

# Fedora iot-simplified-installer uses /dev/vda3, https://github.com/osbuild/osbuild-composer/issues/3527
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this part into line 28?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

henrywang
henrywang requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@henrywang henrywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yih-redhat I have my comment inline. Thanks.

@yih-redhat yih-redhat force-pushed the add-iot-test branch 4 times, most recently from 9d39ada to fa02a51 Compare October 9, 2023 13:19
@yih-redhat
Copy link
Contributor Author

Blocked by bug #3726

@yih-redhat yih-redhat added blocked Issues / PRs blocked by something WIP Work in progress. Don't run Gitlab CI. labels Oct 9, 2023
@yih-redhat yih-redhat force-pushed the add-iot-test branch 3 times, most recently from e8e0c96 to 3fec412 Compare October 19, 2023 13:05
@croissanne
Copy link
Member

Rebased to prevent OCI private key leaking. Apologies :(

@yih-redhat
Copy link
Contributor Author

Need to update snapshot first to use new selinux packages in f39 repo which includes the fix for bug #3726

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jan 4, 2024
auto-merge was automatically disabled January 4, 2024 04:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrywang henrywang henrywang requested changes

@achilleas-k achilleas-k achilleas-k left review comments

Assignees
No one assigned
Labels
blocked Issues / PRs blocked by something Stale WIP Work in progress. Don't run Gitlab CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yih-redhat @achilleas-k @croissanne @henrywang @schutzbot